Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Streaming CSV reads #1479

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[FEAT] Streaming CSV reads #1479

merged 1 commit into from
Oct 9, 2023

Conversation

xcharleslin
Copy link
Contributor

We never had streaming CSV reads at the execution layer, so we would be reading a whole CSV file regardless of how many rows needed. Now we use pyarrow CSV stream reader to get record batches, and from those only get the rows we need.

@github-actions github-actions bot added the enhancement New feature or request label Oct 9, 2023
@xcharleslin xcharleslin marked this pull request as ready for review October 9, 2023 22:38
Copy link
Member

@samster25 samster25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! But can we also test this on a large csv file where we read all the rows to make sure theres no regressions there

Copy link
Contributor

@clarkzinzow clarkzinzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #1479 (99cb476) into main (278e7cd) will increase coverage by 0.16%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1479      +/-   ##
==========================================
+ Coverage   74.64%   74.81%   +0.16%     
==========================================
  Files          60       60              
  Lines        6042     6090      +48     
==========================================
+ Hits         4510     4556      +46     
- Misses       1532     1534       +2     
Files Coverage Δ
daft/table/table.py 82.13% <100.00%> (+0.57%) ⬆️
daft/table/table_io.py 95.83% <100.00%> (+0.18%) ⬆️

... and 3 files with indirect coverage changes

@jaychia jaychia merged commit d69024c into main Oct 9, 2023
24 checks passed
@jaychia jaychia deleted the charles/pacsv-limit branch October 9, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants